This is an archive of the discontinued Mercurial Phabricator instance.

fileserverclient: release memory as files are processed
ClosedPublic

Authored by martinvonz on Sep 20 2018, 1:10 AM.

Reviewers

None

Group Reviewers

Restricted Project

Commits

Summary

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			remotefilelog/fileserverclient.py (5 lines)

	Status	Author	Revision
	Closed	martinvonz	D4669 fileserverclient: release memory as files are processed
	Closed	martinvonz	D4668 fileserverclient: don't wait for all batches getfiles before processing

	with remote.commandexecutor() as e:			with remote.commandexecutor() as e:
	futures = []			futures = []
	for m in missed:			for m in missed:
	futures.append(e.callcommand('getfile', {			futures.append(e.callcommand('getfile', {
	'file': idmap[m],			'file': idmap[m],
	'node': m[-40:]			'node': m[-40:]
	}))			}))

	for m, future in itertools.izip(missed, futures):			for i, m in enumerate(missed):
	r = future.result()			r = futures[i].result()
				futures[i] = None # release memory
	file_ = idmap[m]			file_ = idmap[m]
	node = m[-40:]			node = m[-40:]
	receivemissing(io.BytesIO('%d\n%s' % (len(r), r)), file_, node)			receivemissing(io.BytesIO('%d\n%s' % (len(r), r)), file_, node)
	progresstick()			progresstick()
	return			return

	if (getattr(remote, 'iterbatch', False) and remote.capable('httppostargs')			if (getattr(remote, 'iterbatch', False) and remote.capable('httppostargs')
	and isinstance(remote, httppeer.httppeer)):			and isinstance(remote, httppeer.httppeer)):