This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4734

py3: add b'' prefixes to wire protocol test
ClosedPublic

Authored by indygreg on Sep 24 2018, 11:32 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG34074e8ea160: py3: add b'' prefixes to wire protocol test
Summary

Otherwise the CBOR encoder fails on Python 3 due to lacking support
for encoding str/unicode.

  1. skip-blame just some b'' prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 24 2018, 11:32 PM
Closed by commit rHG34074e8ea160: py3: add b'' prefixes to wire protocol test (authored by indygreg). · Explain WhySep 25 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11347

tests/test-wireproto-command-filedata.t

b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n' b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n'
] ]
Requesting multiple revisions works Requesting multiple revisions works
(first revision is a fulltext since haveparents=False by default) (first revision is a fulltext since haveparents=False by default)
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command filedata > command filedata
> nodes eval:['\x2b\x4e\xb0\x73\x19\xbf\xa0\x77\xa4\x0a\x2f\x04\x91\x36\x59\xae\xf0\xda\x42\xda', '\x9a\x38\x12\x29\x97\xb3\xac\x97\xbe\x2a\x9a\xa2\xe5\x56\x83\x83\x41\xfd\xf2\xcc'] > nodes eval:[b'\x2b\x4e\xb0\x73\x19\xbf\xa0\x77\xa4\x0a\x2f\x04\x91\x36\x59\xae\xf0\xda\x42\xda', b'\x9a\x38\x12\x29\x97\xb3\xac\x97\xbe\x2a\x9a\xa2\xe5\x56\x83\x83\x41\xfd\xf2\xcc']
> path eval:b'a' > path eval:b'a'
> fields eval:[b'revision'] > fields eval:[b'revision']
> EOF > EOF
creating http peer for wire protocol version 2 creating http peer for wire protocol version 2
sending filedata command sending filedata command
s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
}, },
b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n' b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n'
] ]
Revisions are sorted by DAG order, parents first Revisions are sorted by DAG order, parents first
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command filedata > command filedata
> nodes eval:['\x9a\x38\x12\x29\x97\xb3\xac\x97\xbe\x2a\x9a\xa2\xe5\x56\x83\x83\x41\xfd\xf2\xcc', '\x2b\x4e\xb0\x73\x19\xbf\xa0\x77\xa4\x0a\x2f\x04\x91\x36\x59\xae\xf0\xda\x42\xda'] > nodes eval:[b'\x9a\x38\x12\x29\x97\xb3\xac\x97\xbe\x2a\x9a\xa2\xe5\x56\x83\x83\x41\xfd\xf2\xcc', b'\x2b\x4e\xb0\x73\x19\xbf\xa0\x77\xa4\x0a\x2f\x04\x91\x36\x59\xae\xf0\xda\x42\xda']
> path eval:b'a' > path eval:b'a'
> fields eval:[b'revision'] > fields eval:[b'revision']
> EOF > EOF
creating http peer for wire protocol version 2 creating http peer for wire protocol version 2
sending filedata command sending filedata command
s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
}, },
b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n' b'\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03a1\n'
] ]
Requesting parents and revision data works Requesting parents and revision data works
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command filedata > command filedata
> nodes eval:['\x08\x79\x34\x5e\x39\x37\x72\x29\x63\x4b\x42\x0c\x63\x94\x54\x15\x67\x26\xc6\xb6'] > nodes eval:[b'\x08\x79\x34\x5e\x39\x37\x72\x29\x63\x4b\x42\x0c\x63\x94\x54\x15\x67\x26\xc6\xb6']
> path eval:b'a' > path eval:b'a'
> fields eval:[b'parents', b'revision'] > fields eval:[b'parents', b'revision']
> EOF > EOF
creating http peer for wire protocol version 2 creating http peer for wire protocol version 2
sending filedata command sending filedata command
s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n s> POST /api/exp-http-v2-0002/ro/filedata HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n