This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4736

revset: fix commonancestor test so it demonstrates correct behavior
ClosedPublic

Authored by valentin.gatienbaron on Sep 25 2018, 5:18 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf28812c708a5: revset: fix commonancestor test so it demonstrates correct behavior
Summary

The problem is that hg log -r 'head()' is every changeset in the
repository, because in this test repository, every changeset has a
different branch. The author probably assumed all commits were on the
default branch, and that they were getting topological heads, 7 and 9.

As a result, this test was showing that the common ancestors of
0:9 are 0+1+2+4, which is not correct (next commit will test this).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mtests/test-revset.t (2 lines)

Diff 11353

tests/test-revset.t

test common ancestors test common ancestors
$ hg log -T '{rev}\n' -r 'commonancestors(7 + 9)' $ hg log -T '{rev}\n' -r 'commonancestors(7 + 9)'
0 0
1 1
2 2
4 4
$ hg log -T '{rev}\n' -r 'commonancestors(head())' $ hg log -T '{rev}\n' -r 'commonancestors(heads(all()))'
0 0
1 1
2 2
4 4
$ hg log -T '{rev}\n' -r 'commonancestors(9)' $ hg log -T '{rev}\n' -r 'commonancestors(9)'
0 0
1 1