This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4740

revset: reword commonancestor()'s help
ClosedPublic

Authored by valentin.gatienbaron on Sep 25 2018, 5:18 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0561e69ed9f1: revset: reword commonancestor()'s help
Summary

The new version seems a bit more consistent with other doc comments,
and feels clearer to me (doesn't explain "commonancestors(set)" as
"common ancestors of set").

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (2 lines)

Diff 11357

mercurial/revset.py

# merge will find. # merge will find.
h = heads(repo, fullreposet(repo), x, anyorder) h = heads(repo, fullreposet(repo), x, anyorder)
ancs = repo.changelog._commonancestorsheads(*list(h)) ancs = repo.changelog._commonancestorsheads(*list(h))
return subset & baseset(ancs) return subset & baseset(ancs)
@predicate('commonancestors(set)', safe=True) @predicate('commonancestors(set)', safe=True)
def commonancestors(repo, subset, x): def commonancestors(repo, subset, x):
"""Returns all common ancestors of the set. """Changesets that are ancestors of every changeset in set.
""" """
startrevs = getset(repo, fullreposet(repo), x) startrevs = getset(repo, fullreposet(repo), x)
if not startrevs: if not startrevs:
return baseset() return baseset()
for r in startrevs: for r in startrevs:
subset &= dagop.revancestors(repo, baseset([r])) subset &= dagop.revancestors(repo, baseset([r]))
return subset return subset