This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4796

testing: add more testing for ifileindex.lookup()
ClosedPublic

Authored by indygreg on Sep 28 2018, 8:18 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG215fd73cfe52: testing: add more testing for ifileindex.lookup()
Summary

The tests demonstrate some... questionable behavior of revlog.lookup().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 28 2018, 8:18 PM
Closed by commit rHG215fd73cfe52: testing: add more testing for ifileindex.lookup() (authored by indygreg). · Explain WhyOct 3 2018, 11:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/testing/storage.py (38 lines)

Diff 11610

mercurial/testing/storage.py

self.assertEqual(f.lookup(nullid), nullid) self.assertEqual(f.lookup(nullid), nullid)
self.assertEqual(f.lookup(nullrev), nullid) self.assertEqual(f.lookup(nullrev), nullid)
self.assertEqual(f.lookup(hex(nullid)), nullid) self.assertEqual(f.lookup(hex(nullid)), nullid)
# String converted to integer doesn't work for nullrev. # String converted to integer doesn't work for nullrev.
with self.assertRaises(error.LookupError): with self.assertRaises(error.LookupError):
f.lookup(b'%d' % nullrev) f.lookup(b'%d' % nullrev)
with self.assertRaises(error.LookupError):
f.lookup(b'badvalue')
self.assertEqual(f.lookup(hex(nullid)[0:12]), nullid)
with self.assertRaises(error.LookupError):
f.lookup(b'-2')
# TODO this is wonky.
self.assertEqual(f.lookup(b'0'), nullid)
with self.assertRaises(error.LookupError):
f.lookup(b'1')
with self.assertRaises(error.LookupError):
f.lookup(b'11111111111111111111111111111111111111')
for i in range(-5, 5):
if i == nullrev:
continue
with self.assertRaises(LookupError):
f.lookup(i)
self.assertEqual(f.linkrev(nullrev), nullrev) self.assertEqual(f.linkrev(nullrev), nullrev)
for i in range(-5, 5): for i in range(-5, 5):
if i == nullrev: if i == nullrev:
continue continue
with self.assertRaises(IndexError): with self.assertRaises(IndexError):
f.linkrev(i) f.linkrev(i)
self.assertEqual(f.node(0), node) self.assertEqual(f.node(0), node)
with self.assertRaises(IndexError): with self.assertRaises(IndexError):
f.node(1) f.node(1)
self.assertEqual(f.lookup(node), node) self.assertEqual(f.lookup(node), node)
self.assertEqual(f.lookup(0), node) self.assertEqual(f.lookup(0), node)
self.assertEqual(f.lookup(-1), nullid)
self.assertEqual(f.lookup(b'0'), node) self.assertEqual(f.lookup(b'0'), node)
self.assertEqual(f.lookup(hex(node)), node) self.assertEqual(f.lookup(hex(node)), node)
self.assertEqual(f.lookup(hex(node)[0:12]), node)
with self.assertRaises(IndexError):
f.lookup(-2)
with self.assertRaises(error.LookupError):
f.lookup(b'-2')
with self.assertRaises(IndexError):
f.lookup(1)
with self.assertRaises(error.LookupError):
f.lookup(b'1')
self.assertEqual(f.linkrev(0), 0) self.assertEqual(f.linkrev(0), 0)
with self.assertRaises(IndexError): with self.assertRaises(IndexError):
f.linkrev(1) f.linkrev(1)
self.assertFalse(f.iscensored(0)) self.assertFalse(f.iscensored(0))