This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4807

context: stop catching TypeError when converting hex nodeid to binary
ClosedPublic

Authored by martinvonz on Sep 29 2018, 2:14 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8cef57031bbe: context: stop catching TypeError when converting hex nodeid to binary
rHG2e8f4c90610b: context: stop catching TypeError when converting hex nodeid to binary
Summary

It has been a programming error to pass a 40-character string that is
not a hex nodeid since 8b86acc7aa64 (context: drop support for looking
up context by ambiguous changeid (API), 2018-04-28), so we can just
let it raise a TypeError.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 29 2018, 2:14 AM
Closed by commit rHG2e8f4c90610b: context: stop catching TypeError when converting hex nodeid to binary (authored by martinvonz). · Explain WhySep 29 2018, 9:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 11497

mercurial/context.py

elif len(changeid) == 40: elif len(changeid) == 40:
try: try:
self._node = bin(changeid) self._node = bin(changeid)
self._rev = repo.changelog.rev(self._node) self._rev = repo.changelog.rev(self._node)
return return
except error.FilteredLookupError: except error.FilteredLookupError:
raise raise
except (TypeError, LookupError): except LookupError:
pass pass
else: else:
raise error.ProgrammingError( raise error.ProgrammingError(
"unsupported changeid '%s' of type %s" % "unsupported changeid '%s' of type %s" %
(changeid, type(changeid))) (changeid, type(changeid)))
except (error.FilteredIndexError, error.FilteredLookupError): except (error.FilteredIndexError, error.FilteredLookupError):
raise error.FilteredRepoLookupError(_("filtered revision '%s'") raise error.FilteredRepoLookupError(_("filtered revision '%s'")