( )⚙ D4821 localrepo: capture repo interface factory functions as lambas

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4821

localrepo: capture repo interface factory functions as lambas
ClosedPublic

Authored by indygreg on Oct 1 2018, 12:18 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6962ebc8f817: localrepo: capture repo interface factory functions as lambas
Summary

Previously, the list would hold a reference to the original function
and attempting to wrap the module function via extension wouldn't
result in the wrapped function being called, completely undermining
the expected behavior.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 1 2018, 12:18 PM
Closed by commit rHG6962ebc8f817: localrepo: capture repo interface factory functions as lambas (authored by indygreg). · Explain WhyOct 3 2018, 9:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (10 lines)

Diff 11522

mercurial/localrepo.py

# for a dynamically-derived type, which will represent our new repository. # for a dynamically-derived type, which will represent our new repository.
bases = [] bases = []
extrastate = {} extrastate = {}
for iface, fn in REPO_INTERFACES: for iface, fn in REPO_INTERFACES:
# We pass all potentially useful state to give extensions tons of # We pass all potentially useful state to give extensions tons of
# flexibility. # flexibility.
typ = fn(ui=ui, typ = fn()(ui=ui,
intents=intents, intents=intents,
requirements=requirements, requirements=requirements,
features=features, features=features,
wdirvfs=wdirvfs, wdirvfs=wdirvfs,
hgvfs=hgvfs, hgvfs=hgvfs,
store=store, store=store,
storevfs=storevfs, storevfs=storevfs,
storeoptions=storevfs.options, storeoptions=storevfs.options,
if repository.NARROW_REQUIREMENT in requirements: if repository.NARROW_REQUIREMENT in requirements:
return revlognarrowfilestorage return revlognarrowfilestorage
else: else:
return revlogfilestorage return revlogfilestorage
# List of repository interfaces and factory functions for them. Each # List of repository interfaces and factory functions for them. Each
# will be called in order during ``makelocalrepository()`` to iteratively # will be called in order during ``makelocalrepository()`` to iteratively
# derive the final type for a local repository instance. # derive the final type for a local repository instance. We capture the
# function as a lambda so we don't hold a reference and the module-level
# functions can be wrapped.
REPO_INTERFACES = [ REPO_INTERFACES = [
(repository.ilocalrepositorymain, makemain), (repository.ilocalrepositorymain, lambda: makemain),
(repository.ilocalrepositoryfilestorage, makefilestorage), (repository.ilocalrepositoryfilestorage, lambda: makefilestorage),
] ]
@interfaceutil.implementer(repository.ilocalrepositorymain) @interfaceutil.implementer(repository.ilocalrepositorymain)
class localrepository(object): class localrepository(object):
"""Main class for representing local repositories. """Main class for representing local repositories.
All local repositories are instances of this class. All local repositories are instances of this class.