This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4822

tests: add test showing that paths outside narrowspec are not added
ClosedPublic

Authored by martinvonz on Oct 1 2018, 1:01 PM.

Download Raw Diff

Details

Reviewers

durin42

Group Reviewers

hg-reviewers

Commits

rHG277a6fb460a6: tests: add test showing that paths outside narrowspec are not added

Summary

We had a test that shows that trying to explicitly add a file outside
the narrowspec results in an error, but we didn't have a test that
shows that paths from subdirectories outside the narrowspec are not
added (on e.g. hg add .) but silently ignored.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 1 2018, 1:01 PM

Herald added a reviewer: durin42. · View Herald TranscriptOct 1 2018, 1:01 PM

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added a subscriber: mercurial-devel. · View Herald Transcript

martinvonz added a child revision: D4823: narrow: drop unnecessary overrides of patch.Oct 1 2018, 1:01 PM

Closed by commit rHG277a6fb460a6: tests: add test showing that paths outside narrowspec are not added (authored by martinvonz). · Explain WhyOct 1 2018, 1:14 PM

This revision was automatically updated to reflect the committed changes.

martinvonz updated this revision to Diff 11533.Oct 1 2018, 1:15 PM

Revision Contents
Changeset List

			Path	Packages
M			tests/test-narrow-commit.t (1 line)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	11525		Oct 1 2018, 1:01 PM	★	★
Diff 2	11530	rHG277a6fb460a68543516572df2bc560b571379a39	Sep 28 2018, 3:00 AM	★	★
Diff 3	11533		Oct 1 2018, 1:15 PM	★	★

Status	Author	Revision
Closed	martinvonz	D4825 narrow: move copies overrides to core
Closed	martinvonz	D4824 narrow: move support for `hg verify` into core
Closed	martinvonz	D4823 narrow: drop unnecessary overrides of patch
Closed	martinvonz	D4822 tests: add test showing that paths outside narrowspec are not added

Diff 11530

tests/test-narrow-commit.t

	Can not modify dirstate outside			Can not modify dirstate outside

	$ mkdir outside			$ mkdir outside
	$ touch outside/f1			$ touch outside/f1
	$ hg debugwalk -v -I 'relglob:f1'			$ hg debugwalk -v -I 'relglob:f1'
	* matcher:			* matcher:
	<includematcher includes='(?:(?:\|.*/)f1(?:/\|$))'>			<includematcher includes='(?:(?:\|.*/)f1(?:/\|$))'>
	f inside/f1 inside/f1			f inside/f1 inside/f1
				$ hg add .
	$ hg add outside/f1			$ hg add outside/f1
	abort: cannot track 'outside/f1' - it is outside the narrow clone			abort: cannot track 'outside/f1' - it is outside the narrow clone
	[255]			[255]
	$ touch outside/f3			$ touch outside/f3
	$ hg add outside/f3			$ hg add outside/f3
	abort: cannot track 'outside/f3' - it is outside the narrow clone			abort: cannot track 'outside/f3' - it is outside the narrow clone
	[255]			[255]