( )⚙ D4830 bundlerepo: remove a variable alias

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4830

bundlerepo: remove a variable alias
ClosedPublic

Authored by martinvonz on Oct 1 2018, 7:45 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG75b53b809e87: bundlerepo: remove a variable alias
Summary

"parentrepo" and "repo" were the same thing and I don't see much
reason for it (unionrepo has similar structure and a similar alias but
there are two repos there so at least it makes a little more sense
there).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 1 2018, 7:45 PM
Closed by commit rHG75b53b809e87: bundlerepo: remove a variable alias (authored by martinvonz). · Explain WhyOct 1 2018, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundlerepo.py (7 lines)

Diff 11540

mercurial/bundlerepo.py

# #
# So, our strategy is to go through ``localrepo.instance()`` to construct # So, our strategy is to go through ``localrepo.instance()`` to construct
# a repo instance. Then, we dynamically create a new type derived from # a repo instance. Then, we dynamically create a new type derived from
# both it and our ``bundlerepository`` class which overrides some # both it and our ``bundlerepository`` class which overrides some
# functionality. We then change the type of the constructed repository # functionality. We then change the type of the constructed repository
# to this new type and initialize the bundle-specific bits of it. # to this new type and initialize the bundle-specific bits of it.
try: try:
parentrepo = localrepo.instance(ui, repopath, create=False) repo = localrepo.instance(ui, repopath, create=False)
tempparent = None tempparent = None
except error.RepoError: except error.RepoError:
tempparent = pycompat.mkdtemp() tempparent = pycompat.mkdtemp()
try: try:
parentrepo = localrepo.instance(ui, tempparent, create=True) repo = localrepo.instance(ui, tempparent, create=True)
except Exception: except Exception:
shutil.rmtree(tempparent) shutil.rmtree(tempparent)
raise raise
class derivedbundlerepository(bundlerepository, parentrepo.__class__): class derivedbundlerepository(bundlerepository, repo.__class__):
pass pass
repo = parentrepo
repo.__class__ = derivedbundlerepository repo.__class__ = derivedbundlerepository
bundlerepository.__init__(repo, bundlepath, url, tempparent) bundlerepository.__init__(repo, bundlepath, url, tempparent)
return repo return repo
class bundletransactionmanager(object): class bundletransactionmanager(object):
def transaction(self): def transaction(self):
return None return None