( )⚙ D4831 copies: inline a variable that's used only once

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4831

copies: inline a variable that's used only once
ClosedPublic

Authored by martinvonz on Oct 2 2018, 12:26 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG85c8ff26d698: copies: inline a variable that's used only once
Summary

By inlining it, we also avoid calculating the value when "if of in
seen" is false (probably not significant).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 2 2018, 12:26 AM
Closed by commit rHG85c8ff26d698: copies: inline a variable that's used only once (authored by martinvonz). · Explain WhyOct 2 2018, 1:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/copies.py (3 lines)

Diff 11542

mercurial/copies.py

if msrc[f] == mb.get(f) and not remotebase: if msrc[f] == mb.get(f) and not remotebase:
# Nothing to merge # Nothing to merge
return return
of = None of = None
seen = {f} seen = {f}
for oc in getsrcfctx(f, msrc[f]).ancestors(): for oc in getsrcfctx(f, msrc[f]).ancestors():
ocr = oc.linkrev()
of = oc.path() of = oc.path()
if of in seen: if of in seen:
# check limit late - grab last rename before # check limit late - grab last rename before
if ocr < limit: if oc.linkrev() < limit:
break break
continue continue
seen.add(of) seen.add(of)
# remember for dir rename detection # remember for dir rename detection
if backwards: if backwards:
data['fullcopy'][of] = f # grafting backwards through renames data['fullcopy'][of] = f # grafting backwards through renames
else: else: