This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4839

identify: when using -T, avoid unnecessary remote bookmarks query
ClosedPublic

Authored by valentin.gatienbaron on Oct 2 2018, 12:19 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa91398dc73ab: identify: when using -T, avoid unnecessary remote bookmarks query
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Closed by commit rHGa91398dc73ab: identify: when using -T, avoid unnecessary remote bookmarks query (authored by valentin.gatienbaron). · Explain WhyOct 3 2018, 8:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (23 lines)

Diff 11596

mercurial/commands.py

if 'bookmarks' in peer.listkeys('namespaces'): if 'bookmarks' in peer.listkeys('namespaces'):
hexremoterev = hex(remoterev) hexremoterev = hex(remoterev)
bms = [bm for bm, bmr in peer.listkeys('bookmarks').iteritems() bms = [bm for bm, bmr in peer.listkeys('bookmarks').iteritems()
if bmr == hexremoterev] if bmr == hexremoterev]
return sorted(bms) return sorted(bms)
if fm.isplain():
if bookmarks: if bookmarks:
output.extend(getbms()) output.extend(getbms())
elif default and not ui.quiet: elif default and not ui.quiet:
# multiple bookmarks for a single parent separated by '/' # multiple bookmarks for a single parent separated by '/'
bm = '/'.join(getbms()) bm = '/'.join(getbms())
if bm: if bm:
output.append(bm) output.append(bm)
else:
fm.data(node=hex(remoterev)) fm.data(node=hex(remoterev))
if 'bookmarks' in fm.datahint(): if 'bookmarks' in fm.datahint():
fm.data(bookmarks=fm.formatlist(getbms(), name='bookmark')) fm.data(bookmarks=fm.formatlist(getbms(), name='bookmark'))
else: else:
if rev: if rev:
repo = scmutil.unhidehashlikerevs(repo, [rev], 'nowarn') repo = scmutil.unhidehashlikerevs(repo, [rev], 'nowarn')
ctx = scmutil.revsingle(repo, rev, None) ctx = scmutil.revsingle(repo, rev, None)
if ctx.rev() is None: if ctx.rev() is None:
ctx = repo[None] ctx = repo[None]
parents = ctx.parents() parents = ctx.parents()