( )⚙ D4842 treemanifests: make _loadlazy tolerate item not on _lazydirs

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4842

treemanifests: make _loadlazy tolerate item not on _lazydirs
ClosedPublic

Authored by spectral on Oct 2 2018, 6:46 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGda0319e024c0: treemanifests: make _loadlazy tolerate item not on _lazydirs
Summary

I'd like to clean up a few cases where we check for an item in _lazydirs before
calling _loadlazy - this will remove an extraneous dict lookup and make it
slightly more versatile.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/manifest.py (8 lines)

Diff 11583

mercurial/manifest.py

return self._dir + path return self._dir + path
def _loadalllazy(self): def _loadalllazy(self):
for k, (path, node, readsubtree) in self._lazydirs.iteritems(): for k, (path, node, readsubtree) in self._lazydirs.iteritems():
self._dirs[k] = readsubtree(path, node) self._dirs[k] = readsubtree(path, node)
self._lazydirs = {} self._lazydirs = {}
def _loadlazy(self, d): def _loadlazy(self, d):
path, node, readsubtree = self._lazydirs[d] v = self._lazydirs.get(d)
if v:
path, node, readsubtree = v
self._dirs[d] = readsubtree(path, node) self._dirs[d] = readsubtree(path, node)
del self._lazydirs[d] del self._lazydirs[d]
def _loadchildrensetlazy(self, visit): def _loadchildrensetlazy(self, visit):
if not visit: if not visit:
return None return None
if visit == 'all' or visit == 'this': if visit == 'all' or visit == 'this':
self._loadalllazy() self._loadalllazy()
return None return None