Page MenuHomePhabricator

remotefilelog: fix subtle bug I introduced in emitrevisions

Authored by durin42 on Oct 3 2018, 4:46 PM.



Somehow in here we were hitting some cases where basenode was being
set to the same as node, which is Very Bad. This manifested as a rare
live-lock on the client as it looped forever waiting for the revision
to be fetched before trying to apply a delta to the same revision.

Diff Detail

rFBHGX Facebook Mercurial Extensions
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 3 2018, 4:46 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2018, 4:46 PM
quark accepted this revision.Oct 3 2018, 9:52 PM
quark added a subscriber: quark.

Pushed. Thanks!

This revision is now accepted and ready to land.Oct 3 2018, 9:52 PM
This revision was automatically updated to reflect the committed changes.