This is an archive of the discontinued Mercurial Phabricator instance.

obsolete: fixed ValueError when stored note contains ':' char (issue5783)
AbandonedPublic

Authored by Zharaskhan on Oct 4 2018, 6:56 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

The newer version of amend -n 'Some some' accepts
containing ':' char.

The information contained in this note 'Testing::Obstore'
gives ValueError, because we are trying to store more than 2 values
in key and value

The test changes demonstates the bug and it's fix.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Zharaskhan created this revision.Oct 4 2018, 6:56 PM
Zharaskhan retitled this revision from obsolete: fixed ValueError when stored note contains more than 1 ':' char (issue5783) to obsolete: fixed ValueError when stored note contains ':' char (issue5783).Oct 4 2018, 7:20 PM
Zharaskhan edited the summary of this revision. (Show Details)
pulkit accepted this revision.Oct 4 2018, 7:21 PM
pulkit added a subscriber: pulkit.

This series looks good to me but again since I helped Zharas prepare it, I won't queue it.

Zharaskhan abandoned this revision.Oct 6 2018, 5:16 PM