This is an archive of the discontinued Mercurial Phabricator instance.

smartlog: remove temporary hack for old revset compatibility
ClosedPublic

Authored by quark on Jul 11 2017, 5:03 PM.

Reviewers

dsp

Group Reviewers

Restricted Project

Commits

Summary

The old smartlog revset is no longer used.

Test Plan

Confirmed no user uses smartlog('all') or smartlog('recent') by searching
smartlog( globally.

Repository

rFBHGX Facebook Mercurial Extensions

Branch

default

Lint

Lint OK

Unit

Unit Tests OK

dsp accepted this revision.Jul 11 2017, 7:53 PM

This revision is now accepted and ready to land.Jul 11 2017, 7:53 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			hgext3rd/smartlog.py (4 lines)

Commit	Local	Parents	Author	Summary	Date
d7646dce79a1	5582	cbcf24828f51	Jun Wu	smartlog: remove temporary hack for old revset compatibility	Jul 11 2017, 4:40 PM


	args = revset.getargsdict(x, 'smartlogrevset', 'master recentdays')			args = revset.getargsdict(x, 'smartlogrevset', 'master recentdays')
	if 'master' in args:			if 'master' in args:
	masterstring = revsetlang.getstring(args['master'],			masterstring = revsetlang.getstring(args['master'],
	_('master must be a string'))			_('master must be a string'))
	else:			else:
	masterstring = ''			masterstring = ''

	# TODO(quark): remove this after changing Nuclide's smartlog query
	if masterstring == 'all':
	masterstring = ''

	recentdays = revsetlang.getinteger(args.get('recentdays'),			recentdays = revsetlang.getinteger(args.get('recentdays'),
	_("recentdays should be int"), -1)			_("recentdays should be int"), -1)

	revs = set()			revs = set()
	heads = set()			heads = set()

	rev = repo.changelog.rev			rev = repo.changelog.rev
	branchinfo = repo.changelog.branchinfo			branchinfo = repo.changelog.branchinfo