This is an archive of the discontinued Mercurial Phabricator instance.

Differential D49

modcheck: whitelist lz4revlog
ClosedPublic

Authored by quark on Jul 11 2017, 5:07 PM.
Tags
  • Restricted Project
Subscribers
None

Details

Reviewers
phillco
Group Reviewers
Restricted Project
Commits
rFBHGXee31e735b6c2: modcheck: whitelist lz4revlog
Summary

Sometimes test-check-* were skipped. Upon investigation, it's because
lz4revlog was imported and hg printed warnings with modcheck. So let's
make lz4revlog whitelisted.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Jul 11 2017, 5:07 PM
quark added a reviewer: Restricted Project.Jul 11 2017, 5:07 PM
quark changed the repository for this revision from rHG Mercurial to rFBHGX Facebook Mercurial Extensions.
quark removed a subscriber: mercurial-devel.
phillco accepted this revision as: phillco.Jul 11 2017, 5:08 PM
This revision is now accepted and ready to land.Jul 11 2017, 5:08 PM
quark added a project: Restricted Project.Jul 11 2017, 5:16 PM
Closed by commit rFBHGXee31e735b6c2: modcheck: whitelist lz4revlog (authored by quark). · Explain WhyJul 11 2017, 11:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/modcheck.py (2 lines)

Diff 81

tests/modcheck.py

import re import re
import sys import sys
from mercurial import dispatch from mercurial import dispatch
dirname = os.path.dirname dirname = os.path.dirname
# skip checking external modules # skip checking external modules
skipmodre = re.compile(r'\Amysql|remotenames|hgsubversion.*\Z') skipmodre = re.compile(r'\Amysql|remotenames|hgsubversion.*|lz4revlog\Z')
reporoot = dirname(dirname(__file__)) reporoot = dirname(dirname(__file__))
pyroot = dirname(os.__file__) pyroot = dirname(os.__file__)
hgroot = dirname(dirname(dispatch.__file__)) hgroot = dirname(dirname(dispatch.__file__))
def uisetup(ui): def uisetup(ui):
def _modulecheck(): def _modulecheck():
# whitelisted directories # whitelisted directories