Page MenuHomePhabricator

context: always pass a matcher into _matchstatus() (API)
ClosedPublic

Authored by martinvonz on Aug 23 2017, 12:35 PM.

Details

Summary

This just makes it a little easier to follow and removes the need to
call the superclass's method in workingctx.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 23 2017, 12:35 PM
dsp accepted this revision.Aug 24 2017, 1:03 AM
dsp added a subscriber: dsp.

I guess either works. I personally prefer the inheritance here as it feels easier to get it right from an unsuspected caller, but i can see benefits on both sides.

This revision was automatically updated to reflect the committed changes.