This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	indygreg	D4982 exchangev2: use filesdata
Closed	indygreg	D4981 wireprotov2: define and implement "filesdata" command
Closed	indygreg	D4980 wireprotov2: extract file object emission to own function
Closed	indygreg	D4979 wireprotov2: change how revisions are specified to changesetdata
Closed	indygreg	D4978 wireprotov2: stop sending phase updates for base revisions
Closed	indygreg	D4977 debugcommands: support wrapping long lines
Closed	indygreg	D4976 exchangev2: honor server advertised manifestdata recommended batch size
Closed	indygreg	D4975 wireprotov2: advertise recommended batch size for requests
Closed	indygreg	D4974 httppeer: expose API descriptor on httpv2peer
Closed	indygreg	D4973 tests: use baseurl instead of advertisedbaseurl

Diff 11842

	0			0
	)			)

	progress.increment()			progress.increment()

	progress = repo.ui.makeprogress(_('manifests'), unit=_('chunks'),			progress = repo.ui.makeprogress(_('manifests'), unit=_('chunks'),
	total=len(fetchnodes))			total=len(fetchnodes))

	# Fetch manifests 10,000 per command.			commandmeta = remote.apidescriptor[b'commands'][b'manifestdata']
	# TODO have server advertise preferences?			batchsize = commandmeta.get(b'recommendedbatchsize', 10000)
	# TODO make size configurable on client?			# TODO make size configurable on client?
	batchsize = 10000

	# We send commands 1 at a time to the remote. This is not the most			# We send commands 1 at a time to the remote. This is not the most
	# efficient because we incur a round trip at the end of each batch.			# efficient because we incur a round trip at the end of each batch.
	# However, the existing frame-based reactor keeps consuming server			# However, the existing frame-based reactor keeps consuming server
	# data in the background. And this results in response data buffering			# data in the background. And this results in response data buffering
	# in memory. This can consume gigabytes of memory.			# in memory. This can consume gigabytes of memory.
	# TODO send multiple commands in a request once background buffering			# TODO send multiple commands in a request once background buffering
	# issues are resolved.			# issues are resolved.