This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5101

py3: fix test-propertycache.py
ClosedPublic

Authored by mbthomas on Oct 14 2018, 7:50 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd33611280add: py3: fix test-propertycache.py

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Oct 14 2018, 7:50 AM
durin42 added a subscriber: durin42.Oct 14 2018, 8:57 AM
durin42 added inline comments.
tests/test-propertycache.py
48

I believe this should be pycompat.fsdecode instead

mbthomas added inline comments.Oct 14 2018, 10:12 AM
tests/test-propertycache.py
48

It looks like fsencode is the one that goes in the right direction (convert to bytes)

mbthomas updated this revision to Diff 12137.Oct 14 2018, 10:12 AM

Use pycompat.fsencode

Closed by commit rHGd33611280add: py3: fix test-propertycache.py (authored by mbthomas). · Explain WhyOct 14 2018, 11:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-propertycache.py (3 lines)

Diff 12148

tests/test-propertycache.py

"""test behavior of propertycache and unfiltered propertycache """test behavior of propertycache and unfiltered propertycache
The repoview overlay is quite complex. We test the behavior of The repoview overlay is quite complex. We test the behavior of
property cache of both localrepo and repoview to prevent property cache of both localrepo and repoview to prevent
regression.""" regression."""
from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import os import os
import subprocess import subprocess
from mercurial import ( from mercurial import (
hg, hg,
localrepo, localrepo,
pycompat,
ui as uimod, ui as uimod,
util, util,
) )
# create some special property cache that trace they call # create some special property cache that trace they call
calllog = [] calllog = []
@util.propertycache @util.propertycache
#plug them on repo #plug them on repo
localrepo.localrepository.testcachedfoobar = testcachedfoobar localrepo.localrepository.testcachedfoobar = testcachedfoobar
localrepo.localrepository.testcachedunfifoobar = testcachedunfifoobar localrepo.localrepository.testcachedunfifoobar = testcachedunfifoobar
# Create an empty repo and instantiate it. It is important to run # Create an empty repo and instantiate it. It is important to run
# these tests on the real object to detect regression. # these tests on the real object to detect regression.
repopath = os.path.join(os.environ['TESTTMP'], 'repo') repopath = pycompat.fsencode(os.path.join(os.environ['TESTTMP'], 'repo'))
durin42Unsubmitted
Not Done

I believe this should be pycompat.fsdecode instead

durin42: I believe this should be pycompat.fsdecode instead
mbthomasAuthorUnsubmitted
Not Done

It looks like fsencode is the one that goes in the right direction (convert to bytes)

mbthomas: It looks like fsencode is the one that goes in the right direction (convert to bytes)
assert subprocess.call(['hg', 'init', repopath]) == 0 assert subprocess.call(['hg', 'init', repopath]) == 0
ui = uimod.ui.load() ui = uimod.ui.load()
repo = hg.repository(ui, path=repopath).unfiltered() repo = hg.repository(ui, path=repopath).unfiltered()
print('') print('')
print('=== property cache ===') print('=== property cache ===')
print('') print('')