This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5104

tests: use regex instead of Python versions for archive hash changes
ClosedPublic

Authored by durin42 on Oct 14 2018, 8:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6519f5aee06f: tests: use regex instead of Python versions for archive hash changes
Summary

It turns out this behavior changed between versions of Python 3. Let's
just always accept either size or sha1, and move on.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 14 2018, 8:55 AM
Closed by commit rHG6519f5aee06f: tests: use regex instead of Python versions for archive hash changes (authored by durin42). · Explain WhyOct 15 2018, 11:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-archive.t (6 lines)

Diff 12154

tests/test-archive.t

200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.zip content-disposition: attachment; filename=test-archive-1701ef1f1510.zip
content-type: application/zip content-type: application/zip
date: $HTTP_DATE$ date: $HTTP_DATE$
etag: W/"*" (glob) etag: W/"*" (glob)
server: testing stub value server: testing stub value
transfer-encoding: chunked transfer-encoding: chunked
body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3 !) body: size=(1377|1461), sha1=(677b14d3d048778d5eb5552c14a67e6192068650|be6d3983aa13dfe930361b2569291cdedd02b537) (re)
body: size=1461, sha1=be6d3983aa13dfe930361b2569291cdedd02b537 (py3 !)
% tar.gz and tar.bz2 disallowed should both give 403 % tar.gz and tar.bz2 disallowed should both give 403
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii content-type: text/html; charset=ascii
date: $HTTP_DATE$ date: $HTTP_DATE$
etag: W/"*" (glob) etag: W/"*" (glob)
server: testing stub value server: testing stub value
transfer-encoding: chunked transfer-encoding: chunked
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.zip content-disposition: attachment; filename=test-archive-1701ef1f1510.zip
content-type: application/zip content-type: application/zip
date: $HTTP_DATE$ date: $HTTP_DATE$
etag: W/"*" (glob) etag: W/"*" (glob)
server: testing stub value server: testing stub value
transfer-encoding: chunked transfer-encoding: chunked
body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3 !) body: size=(1377|1461), sha1=(677b14d3d048778d5eb5552c14a67e6192068650|be6d3983aa13dfe930361b2569291cdedd02b537) (re)
body: size=1461, sha1=be6d3983aa13dfe930361b2569291cdedd02b537 (py3 !)
% tar.gz and tar.bz2 disallowed should both give 403 % tar.gz and tar.bz2 disallowed should both give 403
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii content-type: text/html; charset=ascii
date: $HTTP_DATE$ date: $HTTP_DATE$
etag: W/"*" (glob) etag: W/"*" (glob)
server: testing stub value server: testing stub value
transfer-encoding: chunked transfer-encoding: chunked