This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5185

storage: update sqlitestore to use the new `deltamode` parameter
ClosedPublic

Authored by lothiraldan on Oct 23 2018, 1:34 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa0e7fa019290: storage: update sqlitestore to use the new `deltamode` parameter
Summary

While updating the filelog class, I forget to update the sqlitestore, tests
are now passing with this patch.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Oct 23 2018, 1:34 PM
Closed by commit rHGa0e7fa019290: storage: update sqlitestore to use the new `deltamode` parameter (authored by lothiraldan). · Explain WhyOct 23 2018, 3:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/sqlitestore.py (5 lines)

Diff 12328

hgext/sqlitestore.py

def renamed(self, node): def renamed(self, node):
return storageutil.filerevisioncopied(self, node) return storageutil.filerevisioncopied(self, node)
def cmp(self, node, fulltext): def cmp(self, node, fulltext):
return not storageutil.filedataequivalent(self, node, fulltext) return not storageutil.filedataequivalent(self, node, fulltext)
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False, def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False): assumehaveparentrevisions=False,
deltamode=repository.CG_DELTAMODE_STD):
if nodesorder not in ('nodes', 'storage', None): if nodesorder not in ('nodes', 'storage', None):
raise error.ProgrammingError('unhandled value for nodesorder: %s' % raise error.ProgrammingError('unhandled value for nodesorder: %s' %
nodesorder) nodesorder)
nodes = [n for n in nodes if n != nullid] nodes = [n for n in nodes if n != nullid]
if not nodes: if not nodes:
return return
deltabases[rev] = res.fetchone()[0] deltabases[rev] = res.fetchone()[0]
# TODO define revdifffn so we can use delta from storage. # TODO define revdifffn so we can use delta from storage.
for delta in storageutil.emitrevisions( for delta in storageutil.emitrevisions(
self, nodes, nodesorder, sqliterevisiondelta, self, nodes, nodesorder, sqliterevisiondelta,
deltaparentfn=deltabases.__getitem__, deltaparentfn=deltabases.__getitem__,
revisiondata=revisiondata, revisiondata=revisiondata,
assumehaveparentrevisions=assumehaveparentrevisions, assumehaveparentrevisions=assumehaveparentrevisions,
deltaprevious=deltaprevious): deltamode=deltamode):
yield delta yield delta
# End of ifiledata interface. # End of ifiledata interface.
# Start of ifilemutation interface. # Start of ifilemutation interface.
def add(self, filedata, meta, transaction, linkrev, p1, p2): def add(self, filedata, meta, transaction, linkrev, p1, p2):