( )⚙ D5246 remotefilelog: avoid accessing repo instance after dispatch

This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: avoid accessing repo instance after dispatch
ClosedPublic

Authored by martinvonz on Nov 9 2018, 1:39 AM.
Tags
None
Subscribers
None

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rFBHGX05ed5d06b353: remotefilelog: avoid accessing repo instance after dispatch
Summary

Upstream commit c5e6c1ba1c79 (hg: don't reuse repo instance after
unshare(), 2018-09-12) poisoned the repo instance after
unshare(). That made hg unshare fail with remotefilelog because we
tried to close the fileserverclient after dispatch by accessing it via
the repo. This patch fixes that by storing the reference to the
fileserverclient at the beginning of dispatch.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped