This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D5258 manifest: perform cheap checks before potentially allocating memory
Closed	durin42	D5257 manifest: also reject obviously-too-short lines when parsing lines
Closed	durin42	D5256 manifest: make sure there's a filename before bothering to look for newline

Diff 12512

	1 byte filename			1 byte filename
	1 NUL			1 NUL
	20 bytes of hash			20 bytes of hash
	so we can give up here.			so we can give up here.
	*/			*/
	return MANIFEST_TOO_SHORT_LINE;			return MANIFEST_TOO_SHORT_LINE;
	}			}
	next++; /* advance past newline */			next++; /* advance past newline */
	if (!realloc_if_full(self)) {
	return MANIFEST_OOM; /* no memory */
	}
	if (prev && strcmp(prev, data) > -1) {			if (prev && strcmp(prev, data) > -1) {
	/* This data isn't sorted, so we have to abort. */			/* This data isn't sorted, so we have to abort. */
	return MANIFEST_NOT_SORTED;			return MANIFEST_NOT_SORTED;
	}			}
				if (!realloc_if_full(self)) {
				return MANIFEST_OOM; /* no memory */
				}
	l = self->lines + ((self->numlines)++);			l = self->lines + ((self->numlines)++);
	l->start = data;			l->start = data;
	l->len = next - data;			l->len = next - data;
	l->hash_suffix = '\0';			l->hash_suffix = '\0';
	l->from_malloc = false;			l->from_malloc = false;
	l->deleted = false;			l->deleted = false;
	len = len - l->len;			len = len - l->len;
	prev = data;			prev = data;