This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5264

store: raise ProgrammingError if unable to decode a storage path
ClosedPublic

Authored by pulkit on Nov 13 2018, 10:49 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG66adfd58cb77: store: raise ProgrammingError if unable to decode a storage path
Summary

Right now, the function magically return False which is dangerous, so let's
raise ProgrammingError.

Suggested by Augie in D5139.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Nov 13 2018, 10:49 AM
Closed by commit rHG66adfd58cb77: store: raise ProgrammingError if unable to decode a storage path (authored by pulkit). · Explain WhyNov 14 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/store.py (2 lines)

Diff 12531

mercurial/store.py

if matcher is None: if matcher is None:
return True return True
path = decodedir(path) path = decodedir(path)
if path.startswith('data/'): if path.startswith('data/'):
return matcher(path[len('data/'):-len('.i')]) return matcher(path[len('data/'):-len('.i')])
elif path.startswith('meta/'): elif path.startswith('meta/'):
return matcher.visitdir(path[len('meta/'):-len('/00manifest.i')] or '.') return matcher.visitdir(path[len('meta/'):-len('/00manifest.i')] or '.')
raise error.ProgrammingError("cannot decode path %s" % path)
# This avoids a collision between a file named foo and a dir named # This avoids a collision between a file named foo and a dir named
# foo.i or foo.d # foo.i or foo.d
def _encodedir(path): def _encodedir(path):
''' '''
>>> _encodedir(b'data/foo.i') >>> _encodedir(b'data/foo.i')
'data/foo.i' 'data/foo.i'
>>> _encodedir(b'data/foo.i/bla.i') >>> _encodedir(b'data/foo.i/bla.i')
'data/foo.i.hg/bla.i' 'data/foo.i.hg/bla.i'