( )⚙ D5280 changegroup: avoid instantiating storage if we are not using it

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5280

changegroup: avoid instantiating storage if we are not using it
ClosedPublic

Authored by spectral on Nov 15 2018, 5:40 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdba590f27c7a: changegroup: avoid instantiating storage if we are not using it

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Nov 15 2018, 5:40 PM
Closed by commit rHGdba590f27c7a: changegroup: avoid instantiating storage if we are not using it (authored by spectral). · Explain WhyNov 17 2018, 1:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (11 lines)

Diff 12552

mercurial/changegroup.py

fclnode = fclnodes.setdefault(n, clnode) fclnode = fclnodes.setdefault(n, clnode)
if clrevorder[clnode] < clrevorder[fclnode]: if clrevorder[clnode] < clrevorder[fclnode]:
fclnodes[n] = clnode fclnodes[n] = clnode
return clnode return clnode
return lookupmflinknode return lookupmflinknode
while tmfnodes: while tmfnodes:
tree, nodes = tmfnodes.popitem() tree, nodes = tmfnodes.popitem()
should_visit = self._matcher.visitdir(tree[:-1] or '.')
if tree and not should_visit:
continue
store = mfl.getstorage(tree) store = mfl.getstorage(tree)
if not self._matcher.visitdir(store.tree[:-1] or '.'): if not should_visit:
# No nodes to send because this directory is out of # No nodes to send because this directory is out of
# the client's view of the repository (probably # the client's view of the repository (probably
# because of narrow clones). # because of narrow clones). Do this even for the root
# directory (tree=='')
prunednodes = [] prunednodes = []
else: else:
# Avoid sending any manifest nodes we can prove the # Avoid sending any manifest nodes we can prove the
# client already has by checking linkrevs. See the # client already has by checking linkrevs. See the
# related comment in generatefiles(). # related comment in generatefiles().
prunednodes = self._prunemanifests(store, nodes, commonrevs) prunednodes = self._prunemanifests(store, nodes, commonrevs)
if tree and not prunednodes: if tree and not prunednodes:
continue continue
lookupfn = makelookupmflinknode(tree, nodes) lookupfn = makelookupmflinknode(tree, nodes)
deltas = deltagroup( deltas = deltagroup(
self._repo, store, prunednodes, False, lookupfn, self._repo, store, prunednodes, False, lookupfn,
self._forcedeltaparentprev, self._forcedeltaparentprev,