This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5282

logtoprocess: update commandfinish options arguments
ClosedPublic

Authored by lothiraldan on Nov 16 2018, 8:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1243295fcc3a: logtoprocess: update commandfinish options arguments
Summary

d2c997b8001f changed the logtoprocess API with the effect of not exposing the
positional arguments to the logtoprocess scripts anymore.

We have some scripts that use the duration and return code of the
"commandfinish" event to monitor hg calls. Update the logging of the
"commandfinish" to expose those values as options argument, which will be
accessible as OPT_RETURN_CODE and OPT_DURATION in logtoprocess arguments.

The code has been formatted with Black.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Nov 16 2018, 8:33 AM
Closed by commit rHG1243295fcc3a: logtoprocess: update commandfinish options arguments (authored by lothiraldan). · Explain WhyNov 16 2018, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (14 lines)

Diff 12556

mercurial/dispatch.py

ret = -1 ret = -1
finally: finally:
duration = util.timer() - starttime duration = util.timer() - starttime
req.ui.flush() req.ui.flush()
if req.ui.logblockedtimes: if req.ui.logblockedtimes:
req.ui._blockedtimes['command_duration'] = duration * 1000 req.ui._blockedtimes['command_duration'] = duration * 1000
req.ui.log('uiblocked', 'ui blocked ms', req.ui.log('uiblocked', 'ui blocked ms',
**pycompat.strkwargs(req.ui._blockedtimes)) **pycompat.strkwargs(req.ui._blockedtimes))
req.ui.log("commandfinish", "%s exited %d after %0.2f seconds\n", return_code = ret & 255
msg, ret & 255, duration, req.ui.log(
canonical_command=req.canonical_command) "commandfinish",
"%s exited %d after %0.2f seconds\n",
msg,
return_code,
duration,
return_code=return_code,
duration=duration,
canonical_command=req.canonical_command,
)
try: try:
req._runexithandlers() req._runexithandlers()
except: # exiting, so no re-raises except: # exiting, so no re-raises
ret = ret or -1 ret = ret or -1
return ret return ret
def _runcatch(req): def _runcatch(req):
with tracing.log('dispatch._runcatch'): with tracing.log('dispatch._runcatch'):