This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Needs Revision	pulkit	D5308 store: don't pass 'atomictemp=True' while appending to fncache
	Closed	pulkit	D5307 store: write fncache only once if there are both adds and removes

Diff 12611

	if not line.rstrip('\n'):			if not line.rstrip('\n'):
	t = _('invalid entry in fncache, line %d') % (n + 1)			t = _('invalid entry in fncache, line %d') % (n + 1)
	raise error.Abort(t)			raise error.Abort(t)
	fp.close()			fp.close()

	def write(self, tr):			def write(self, tr):
	if self._dirty:			if self._dirty:
	assert self.entries is not None			assert self.entries is not None
				self.entries = self.entries \| self.addls
				self.addls = set()
	tr.addbackup('fncache')			tr.addbackup('fncache')
	fp = self.vfs('fncache', mode='wb', atomictemp=True)			fp = self.vfs('fncache', mode='wb', atomictemp=True)
	if self.entries:			if self.entries:
	fp.write(encodedir('\n'.join(self.entries) + '\n'))			fp.write(encodedir('\n'.join(self.entries) + '\n'))
	fp.close()			fp.close()
	self._dirty = False			self._dirty = False
	if self.addls:			if self.addls:
	# if we have just new entries, let's append them to the fncache			# if we have just new entries, let's append them to the fncache