This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5351

match: use _BASE_SIZE instead of magic value 4
ClosedPublic

Authored by martinvonz on Dec 2 2018, 4:53 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe115a6452b41: match: use _BASE_SIZE instead of magic value 4
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 2 2018, 4:53 PM
Closed by commit rHGe115a6452b41: match: use _BASE_SIZE instead of magic value 4 (authored by martinvonz). · Explain WhyDec 3 2018, 5:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/match.py (2 lines)

Diff 12671

mercurial/match.py

allgroups = [] allgroups = []
regexps = [_regex(k, p, globsuffix) for (k, p, s) in kindpats] regexps = [_regex(k, p, globsuffix) for (k, p, s) in kindpats]
fullregexp = _joinregexes(regexps) fullregexp = _joinregexes(regexps)
startidx = 0 startidx = 0
groupsize = _BASE_SIZE groupsize = _BASE_SIZE
for idx, r in enumerate(regexps): for idx, r in enumerate(regexps):
piecesize = len(r) piecesize = len(r)
if (piecesize + 4) > MAX_RE_SIZE: if (piecesize + _BASE_SIZE) > MAX_RE_SIZE:
msg = _("matcher pattern is too long (%d bytes)") % piecesize msg = _("matcher pattern is too long (%d bytes)") % piecesize
raise error.Abort(msg) raise error.Abort(msg)
elif (groupsize + piecesize) > MAX_RE_SIZE: elif (groupsize + piecesize) > MAX_RE_SIZE:
group = regexps[startidx:idx] group = regexps[startidx:idx]
allgroups.append(_joinregexes(group)) allgroups.append(_joinregexes(group))
startidx = idx startidx = idx
groupsize = _BASE_SIZE groupsize = _BASE_SIZE
groupsize += piecesize + 1 groupsize += piecesize + 1