This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5407

perf: add perfprogress command
ClosedPublic

Authored by indygreg on Dec 10 2018, 3:15 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG008f3491dc53: perf: add perfprogress command
Summary

I've noticed that progress bars can add significant overhead to tight
loops. Let's add a perf command that attempts to isolate that overhead.

With a default hgrc, iteration over 1M items appears to take ~3.75s on
my machine. Profiling reveals ~28% of time is spent in ui.configbool()
resolving the value of the progress.debug config option.

Even if I set progress.disable=true, execution still takes ~2.60s, with
~59% of the time spent in ui.configbool().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Dec 10 2018, 3:15 PM
Closed by commit rHG008f3491dc53: perf: add perfprogress command (authored by indygreg). · Explain WhyDec 10 2018, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (18 lines)
Mtests/test-contrib-perf.t (2 lines)

Diff 12819

contrib/perf.py

# openrevlog() should cause failure, because it has been # openrevlog() should cause failure, because it has been
# available since 3.5 (or 49c583ca48c4). # available since 3.5 (or 49c583ca48c4).
def openrevlog(orig, repo, cmd, file_, opts): def openrevlog(orig, repo, cmd, file_, opts):
if opts.get(b'dir') and not util.safehasattr(repo, b'dirlog'): if opts.get(b'dir') and not util.safehasattr(repo, b'dirlog'):
raise error.Abort(b"This version doesn't support --dir option", raise error.Abort(b"This version doesn't support --dir option",
hint=b"use 3.5 or later") hint=b"use 3.5 or later")
return orig(repo, cmd, file_, opts) return orig(repo, cmd, file_, opts)
extensions.wrapfunction(cmdutil, b'openrevlog', openrevlog) extensions.wrapfunction(cmdutil, b'openrevlog', openrevlog)
@command(b'perfprogress', formatteropts + [
(b'', b'topic', b'topic', b'topic for progress messages'),
(b'c', b'total', 1000000, b'total value we are progressing to'),
], norepo=True)
def perfprogress(ui, topic=None, total=None, **opts):
"""printing of progress bars"""
opts = _byteskwargs(opts)
timer, fm = gettimer(ui, opts)
def doprogress():
with ui.makeprogress(topic, total=total) as progress:
for i in pycompat.xrange(total):
progress.increment()
timer(doprogress)
fm.end()

tests/test-contrib-perf.t

perfnodelookup perfnodelookup
(no help text available) (no help text available)
perfparents (no help text available) perfparents (no help text available)
perfpathcopies perfpathcopies
benchmark the copy tracing logic benchmark the copy tracing logic
perfphases benchmark phasesets computation perfphases benchmark phasesets computation
perfphasesremote perfphasesremote
benchmark time needed to analyse phases of the remote server benchmark time needed to analyse phases of the remote server
perfprogress printing of progress bars
perfrawfiles (no help text available) perfrawfiles (no help text available)
perfrevlogchunks perfrevlogchunks
Benchmark operations on revlog chunks. Benchmark operations on revlog chunks.
perfrevlogindex perfrevlogindex
Benchmark operations against a revlog index. Benchmark operations against a revlog index.
perfrevlogrevision perfrevlogrevision
Benchmark obtaining a revlog revision. Benchmark obtaining a revlog revision.
perfrevlogrevisions perfrevlogrevisions
$ hg perfmanifest -m 44fe2c8352bb3a478ffd7d8350bbc721920134d1 $ hg perfmanifest -m 44fe2c8352bb3a478ffd7d8350bbc721920134d1
$ hg perfmanifest -m 44fe2c8352bb $ hg perfmanifest -m 44fe2c8352bb
abort: manifest revision must be integer or full node abort: manifest revision must be integer or full node
[255] [255]
$ hg perfmergecalculate -r 3 $ hg perfmergecalculate -r 3
$ hg perfmoonwalk $ hg perfmoonwalk
$ hg perfnodelookup 2 $ hg perfnodelookup 2
$ hg perfpathcopies 1 2 $ hg perfpathcopies 1 2
$ hg perfprogress --total 1000
$ hg perfrawfiles 2 $ hg perfrawfiles 2
$ hg perfrevlogindex -c $ hg perfrevlogindex -c
#if reporevlogstore #if reporevlogstore
$ hg perfrevlogrevisions .hg/store/data/a.i $ hg perfrevlogrevisions .hg/store/data/a.i
#endif #endif
$ hg perfrevlogrevision -m 0 $ hg perfrevlogrevision -m 0
$ hg perfrevlogchunks -c $ hg perfrevlogchunks -c
$ hg perfrevrange $ hg perfrevrange