This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5429

check-commit: disallow capitalization only right after topic
ClosedPublic

Authored by martinvonz on Dec 14 2018, 4:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG811f772b44aa: check-commit: disallow capitalization only right after topic
rHG7da54cff8743: check-commit: disallow capitalization only right after topic
Summary

It should be okay to write "topic: change 'default: True' to 'default:
on'".

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mcontrib/check-commit (2 lines)

Diff 12860

contrib/check-commit

(beforepatch + r".*[(]bc[)]", "(BC) needs to be uppercase"), (beforepatch + r".*[(]bc[)]", "(BC) needs to be uppercase"),
(beforepatch + r".*[(]issue \d\d\d", (beforepatch + r".*[(]issue \d\d\d",
"no space allowed between issue and number"), "no space allowed between issue and number"),
(beforepatch + r".*[(]bug(\d|\s)", "use (issueDDDD) instead of bug"), (beforepatch + r".*[(]bug(\d|\s)", "use (issueDDDD) instead of bug"),
(commitheader + r"# User [^@\n]+\n", "username is not an email address"), (commitheader + r"# User [^@\n]+\n", "username is not an email address"),
(commitheader + r"(?!merge with )[^#]\S+[^:] ", (commitheader + r"(?!merge with )[^#]\S+[^:] ",
"summary line doesn't start with 'topic: '"), "summary line doesn't start with 'topic: '"),
(afterheader + r"[A-Z][a-z]\S+", "don't capitalize summary lines"), (afterheader + r"[A-Z][a-z]\S+", "don't capitalize summary lines"),
(afterheader + r"[^\n]*: *[A-Z][a-z]\S+", "don't capitalize summary lines"), (afterheader + r"^\S+: *[A-Z][a-z]\S+", "don't capitalize summary lines"),
(afterheader + r"\S*[^A-Za-z0-9-_]\S*: ", (afterheader + r"\S*[^A-Za-z0-9-_]\S*: ",
"summary keyword should be most user-relevant one-word command or topic"), "summary keyword should be most user-relevant one-word command or topic"),
(afterheader + r".*\.\s*\n", "don't add trailing period on summary line"), (afterheader + r".*\.\s*\n", "don't add trailing period on summary line"),
(afterheader + r".{79,}", "summary line too long (limit is 78)"), (afterheader + r".{79,}", "summary line too long (limit is 78)"),
# Forbid "_" in function name. # Forbid "_" in function name.
# #
# We skip the check for cffi related functions. They use names mapping the # We skip the check for cffi related functions. They use names mapping the
# name of the C function. C function names may contain "_". # name of the C function. C function names may contain "_".