This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5507

narrow: drop now-unnecessary reassignment of repo attributes
ClosedPublic

Authored by martinvonz on Jan 7 2019, 3:45 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa2ae27993e16: narrow: drop now-unnecessary reassignment of repo attributes
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (6 lines)

Diff 13147

mercurial/localrepo.py

return matchmod.intersectmatchers(match, nm) return matchmod.intersectmatchers(match, nm)
return matchmod.intersectmatchers(match, self._narrowmatch) return matchmod.intersectmatchers(match, self._narrowmatch)
return self._narrowmatch return self._narrowmatch
def setnarrowpats(self, newincludes, newexcludes): def setnarrowpats(self, newincludes, newexcludes):
narrowspec.save(self, newincludes, newexcludes) narrowspec.save(self, newincludes, newexcludes)
narrowspec.copytoworkingcopy(self) narrowspec.copytoworkingcopy(self)
self.invalidate(clearfilecache=True) self.invalidate(clearfilecache=True)
# So the next access won't be considered a conflict
# TODO: It seems like there should be a way of doing this that
# doesn't involve replacing these attributes.
self.narrowpats = newincludes, newexcludes
self._narrowmatch = narrowspec.match(self.root, include=newincludes,
exclude=newexcludes)
def __getitem__(self, changeid): def __getitem__(self, changeid):
if changeid is None: if changeid is None:
return context.workingctx(self) return context.workingctx(self)
if isinstance(changeid, context.basectx): if isinstance(changeid, context.basectx):
return changeid return changeid
if isinstance(changeid, slice): if isinstance(changeid, slice):
# wdirrev isn't contiguous so the slice shouldn't include it # wdirrev isn't contiguous so the slice shouldn't include it