Page MenuHomePhabricator

style: run yapf on a subset of mercurial
Needs RevisionPublic

Authored by durin42 on Jan 9 2019, 3:28 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

I've tried to pick knobs that more or less conform to our current
style. I ran the formatter on the same set of files as the black
proposal (see D5064), but it resulted in many fewer edits.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 9 2019, 3:28 PM

I see a few minor issues here, but it's at least plausible?

mercurial/minifileset.py
57–58
mercurial/scmwindows.py
53

We could force this to one-per-line by adding a trailing comma.

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM