I've tried to pick knobs that more or less conform to our current
style. I ran the formatter on the same set of files as the black
proposal (see D5064), but it resulted in many fewer edits.
Details
Details
- Reviewers
baymax - Group Reviewers
hg-reviewers
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
I see a few minor issues here, but it's at least plausible?
mercurial/minifileset.py | ||
---|---|---|
57–58 | yapf bug here, filed as https://github.com/google/yapf/issues/662 | |
mercurial/scmwindows.py | ||
53 | We could force this to one-per-line by adding a trailing comma. |
Comment Actions
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the need-review state.
Please, move it back to need-review without hesitation if this diff should still be discussed.
:baymax:need-review-idle:
yapf bug here, filed as https://github.com/google/yapf/issues/662