This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5618

bdiff: drop duplicate definition of splitnewlines()
ClosedPublic

Authored by martinvonz on Jan 16 2019, 8:09 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8b7973d40a01: bdiff: drop duplicate definition of splitnewlines()
Summary

It was added in 29dd37a418aa (bdiff: write a native version of
splitnewlines, 2018-01-25).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 16 2019, 8:09 PM
pulkit accepted this revision.Jan 17 2019, 4:51 AM
Closed by commit rHG8b7973d40a01: bdiff: drop duplicate definition of splitnewlines() (authored by martinvonz). · Explain WhyJan 17 2019, 5:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/bdiff.py (10 lines)

Diff 13311

mercurial/pure/bdiff.py

def fixws(text, allws): def fixws(text, allws):
if allws: if allws:
text = re.sub('[ \t\r]+', '', text) text = re.sub('[ \t\r]+', '', text)
else: else:
text = re.sub('[ \t\r]+', ' ', text) text = re.sub('[ \t\r]+', ' ', text)
text = text.replace(' \n', '\n') text = text.replace(' \n', '\n')
return text return text
def splitnewlines(text):
'''like str.splitlines, but only split on newlines.'''
lines = [l + '\n' for l in text.split('\n')]
if lines:
if lines[-1] == '\n':
lines.pop()
else:
lines[-1] = lines[-1][:-1]
return lines