Page MenuHomePhabricator

scmutil: drop unreachable except clause
ClosedPublic

Authored by martinvonz on Jan 17 2019, 12:49 AM.

Details

Summary

socket.error is a subclass of IOError, which we catch higher up. It
seems to have been this way since 020a896a5292 (dispatch: sort
exception handlers, 2009-01-12), so let's celebrate the 10 year
anniversary (a few days late) of it being wrong by deleting it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 17 2019, 12:49 AM
yuja added a subscriber: yuja.Jan 18 2019, 7:29 AM

Queued, thanks.

socket.error is a subclass of IOError, which we catch higher up. It

For the record, it's Python 2.6 feature.

https://docs.python.org/2.7/library/socket.html#socket.error

This revision was automatically updated to reflect the committed changes.