This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5644

largefiles: avoid walking full manifest
ClosedPublic

Authored by martinvonz on Jan 22 2019, 2:02 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4a409c19831f: largefiles: avoid walking full manifest
Summary

When using treemanifest, diffs between two manifests can often be much
cheaper than iterating the full manifests (because common subtrees are
skipped).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jan 22 2019, 2:02 PM
Closed by commit rHG4a409c19831f: largefiles: avoid walking full manifest (authored by martinvonz). · Explain WhyJan 26 2019, 3:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/lfcommands.py (9 lines)

Diff 13340

hgext/largefiles/lfcommands.py

rdst.setparents(ret) rdst.setparents(ret)
revmap[ctx.node()] = rdst.changelog.tip() revmap[ctx.node()] = rdst.changelog.tip()
# Generate list of changed files # Generate list of changed files
def _getchangedfiles(ctx, parents): def _getchangedfiles(ctx, parents):
files = set(ctx.files()) files = set(ctx.files())
if node.nullid not in parents: if node.nullid not in parents:
mc = ctx.manifest() mc = ctx.manifest()
mp1 = ctx.parents()[0].manifest() for pctx in ctx.parents():
mp2 = ctx.parents()[1].manifest() for fn in pctx.manifest().diff(mc):
files |= (set(mp1) | set(mp2)) - set(mc) files.add(fn)
for f in mc:
if mc[f] != mp1.get(f, None) or mc[f] != mp2.get(f, None):
files.add(f)
return files return files
# Convert src parents to dst parents # Convert src parents to dst parents
def _convertparents(ctx, revmap): def _convertparents(ctx, revmap):
parents = [] parents = []
for p in ctx.parents(): for p in ctx.parents():
parents.append(revmap[p.node()]) parents.append(revmap[p.node()])
while len(parents) < 2: while len(parents) < 2: