This is an archive of the discontinued Mercurial Phabricator instance.

config: reject str sections and keys on Python 3
ClosedPublic

Authored by indygreg on Jan 22 2019, 9:44 PM.

Details

Summary

Otherwise we could end up with a dict having both the str
and bytes versions of a particular config item. This may cause
some tests to regress. I haven't checked. But it is better
behavior to fail fast.

We could just as easily change this to normalize the values. But
I like catching all non-compliant call sites first.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 22 2019, 9:44 PM
This revision was automatically updated to reflect the committed changes.