This is an archive of the discontinued Mercurial Phabricator instance.

tests: handle string escaping/encoding on Python 3
ClosedPublic

Authored by indygreg on Jan 23 2019, 8:58 PM.

Details

Summary

This code was failing on Python 3 for a few reasons:

  1. sys.argv is str and str doesn't have a .decode()
  2. the "string_escape" encoding was renamed to "unicode_escape"

It is wonky casting to bytes to str to bytes. But this is test
code, so meh. I don't believe we exercise any code paths in these
tests where the arguments aren't ascii.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 23 2019, 8:58 PM
This revision was automatically updated to reflect the committed changes.