( )⚙ D5675 cleanup: use clang-tidy to add missing {} around one-line statements

This is an archive of the discontinued Mercurial Phabricator instance.

cleanup: use clang-tidy to add missing {} around one-line statements
ClosedPublic

Authored by durin42 on Jan 24 2019, 10:22 AM.

Details

Summary

I find this easier to read. Cleanup performed like this:

hg files 'set:(.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"' | while read f ; do

clang-tidy -fix -checks=readability-braces-around-statements $f -- $(python-config --cflags) -Imercurial/cext -Imercurial

done
make format-c

I had to revert chg/chg.c as it's got a construct that seems to confuse
clang-tidy, so I'll work on that file later if this change is acceptable. I
only tackle files that are under clang-format's authority because otherwise
I'd have to do a bunch of manual formatting. A few files didn't get edited
because clang-tidy couldn't find some headers. Again, I'll figure that out
later assuming this change is accepted.

No check-code rule added for now because writing the regex sounds hard. In a
perfect world I guess we could write a test that uses clang-tidy on these
files, but I think clang-tidy is pretty rarely installed. :/

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 24 2019, 10:22 AM
durin42 edited the summary of this revision. (Show Details)Jan 24 2019, 10:27 AM
durin42 updated this revision to Diff 13395.
pulkit accepted this revision.Jan 24 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.