This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5677

py3: add missing b prefixes in test-acl.t
ClosedPublic

Authored by durin42 on Jan 24 2019, 11:40 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG671d5a712237: py3: add missing b prefixes in test-acl.t
Summary

There's one failure left in the test, which looks like a real problem
around executing hooks. I have not investigated further.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 24 2019, 11:40 AM
pulkit accepted this revision.Jan 24 2019, 11:47 AM
pulkit added a comment.Jan 24 2019, 11:49 AM

added # skip-blame to commit message in flight.

Closed by commit rHG671d5a712237: py3: add missing b prefixes in test-acl.t (authored by durin42). · Explain WhyJan 24 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-acl.t (2 lines)

Diff 13401

tests/test-acl.t

> init_config() > init_config()
> { > {
> cat > fakegroups.py <<EOF > cat > fakegroups.py <<EOF
> from hgext import acl > from hgext import acl
> def fakegetusers(ui, group): > def fakegetusers(ui, group):
> try: > try:
> return acl._getusersorig(ui, group) > return acl._getusersorig(ui, group)
> except: > except:
> return ["fred", "betty"] > return [b"fred", b"betty"]
> acl._getusersorig = acl._getusers > acl._getusersorig = acl._getusers
> acl._getusers = fakegetusers > acl._getusers = fakegetusers
> EOF > EOF
> rm -f acl.config > rm -f acl.config
> cat > $config <<EOF > cat > $config <<EOF
> [hooks] > [hooks]
> pretxnchangegroup.acl = python:hgext.acl.hook > pretxnchangegroup.acl = python:hgext.acl.hook
> prepushkey.acl = python:hgext.acl.hook > prepushkey.acl = python:hgext.acl.hook