This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5729

convert: print exception message directly
ClosedPublic

Authored by indygreg on Jan 26 2019, 8:00 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG26761665bdfe: convert: print exception message directly
Summary

Otherwise the default repr() implementation will b'' prefix the
returned str on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 26 2019, 8:00 PM
pulkit accepted this revision.Jan 27 2019, 2:57 PM
Closed by commit rHG26761665bdfe: convert: print exception message directly (authored by indygreg). · Explain WhyJan 27 2019, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/convcmd.py (2 lines)

Diff 13539

hgext/convert/convcmd.py

for name, source, sortmode in source_converters: for name, source, sortmode in source_converters:
try: try:
if not type or name == type: if not type or name == type:
return source(ui, name, path, revs), sortmode return source(ui, name, path, revs), sortmode
except (NoRepo, MissingTool) as inst: except (NoRepo, MissingTool) as inst:
exceptions.append(inst) exceptions.append(inst)
if not ui.quiet: if not ui.quiet:
for inst in exceptions: for inst in exceptions:
ui.write("%s\n" % pycompat.bytestr(inst)) ui.write("%s\n" % pycompat.bytestr(inst.args[0]))
raise error.Abort(_('%s: missing or unsupported repository') % path) raise error.Abort(_('%s: missing or unsupported repository') % path)
def convertsink(ui, path, type): def convertsink(ui, path, type):
if type and type not in [s[0] for s in sink_converters]: if type and type not in [s[0] for s in sink_converters]:
raise error.Abort(_('%s: invalid destination repository type') % type) raise error.Abort(_('%s: invalid destination repository type') % type)
for name, sink in sink_converters: for name, sink in sink_converters:
try: try:
if not type or name == type: if not type or name == type: