( )⚙ D5732 changegroup: initialize the state variable a bit earlier

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5732

changegroup: initialize the state variable a bit earlier
ClosedPublic

Authored by pulkit on Jan 29 2019, 8:07 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG73a33fe625bb: changegroup: initialize the state variable a bit earlier
Summary

This will make the next patch much easier.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (14 lines)

Diff 13554

mercurial/changegroup.py

chunk stream has been fully consumed. chunk stream has been fully consumed.
""" """
clrevorder = {} clrevorder = {}
manifests = {} manifests = {}
mfl = self._repo.manifestlog mfl = self._repo.manifestlog
changedfiles = set() changedfiles = set()
clrevtomanifestrev = {} clrevtomanifestrev = {}
state = {
'clrevorder': clrevorder,
'manifests': manifests,
'changedfiles': changedfiles,
'clrevtomanifestrev': clrevtomanifestrev,
}
# Callback for the changelog, used to collect changed files and # Callback for the changelog, used to collect changed files and
# manifest nodes. # manifest nodes.
# Returns the linkrev node (identity in the changelog case). # Returns the linkrev node (identity in the changelog case).
def lookupcl(x): def lookupcl(x):
c = cl.changelogrevision(x) c = cl.changelogrevision(x)
clrevorder[x] = len(clrevorder) clrevorder[x] = len(clrevorder)
if self._ellipses: if self._ellipses:
# record the first changeset introducing this manifest version # record the first changeset introducing this manifest version
manifests.setdefault(c.manifest, x) manifests.setdefault(c.manifest, x)
# Record a complete list of potentially-changed files in # Record a complete list of potentially-changed files in
# this manifest. # this manifest.
changedfiles.update(c.files) changedfiles.update(c.files)
return x return x
state = {
'clrevorder': clrevorder,
'manifests': manifests,
'changedfiles': changedfiles,
'clrevtomanifestrev': clrevtomanifestrev,
}
gen = deltagroup( gen = deltagroup(
self._repo, cl, nodes, True, lookupcl, self._repo, cl, nodes, True, lookupcl,
self._forcedeltaparentprev, self._forcedeltaparentprev,
ellipses=self._ellipses, ellipses=self._ellipses,
topic=_('changesets'), topic=_('changesets'),
clrevtolocalrev={}, clrevtolocalrev={},
fullclnodes=self._fullclnodes, fullclnodes=self._fullclnodes,
precomputedellipsis=self._precomputedellipsis) precomputedellipsis=self._precomputedellipsis)