This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5757

tests: use items() in test-remotefilelog-datapack.py
ClosedPublic

Authored by indygreg on Jan 30 2019, 4:37 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6309ce86fa82: tests: use items() in test-remotefilelog-datapack.py
rHG06b438e335a8: tests: use items() in test-remotefilelog-datapack.py
rHG59854e657999: tests: use items() in test-remotefilelog-datapack.py
Summary

Performance doesn't matter in tests. iteritems() doesn't exist
in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

Diff 13594

tests/test-remotefilelog-datapack.py

lastnode = filerevs[random.randint(0, len(filerevs) - 1)] lastnode = filerevs[random.randint(0, len(filerevs) - 1)]
filerevs.append(node) filerevs.append(node)
blobs[(filename, node, lastnode)] = content blobs[(filename, node, lastnode)] = content
revisions.append((filename, node, lastnode, content)) revisions.append((filename, node, lastnode, content))
pack = self.createPack(revisions) pack = self.createPack(revisions)
# Verify the pack contents # Verify the pack contents
for (filename, node, lastnode), content in sorted(blobs.iteritems()): for (filename, node, lastnode), content in sorted(blobs.items()):
chain = pack.getdeltachain(filename, node) chain = pack.getdeltachain(filename, node)
for entry in chain: for entry in chain:
expectedcontent = blobs[(entry[0], entry[1], entry[3])] expectedcontent = blobs[(entry[0], entry[1], entry[3])]
self.assertEqual(entry[4], expectedcontent) self.assertEqual(entry[4], expectedcontent)
def testPackMetadata(self): def testPackMetadata(self):
revisions = [] revisions = []
for i in range(100): for i in range(100):
blobs[(filename, node)] = content blobs[(filename, node)] = content
revisions.append((filename, node, nullid, content)) revisions.append((filename, node, nullid, content))
pack = self.createPack(revisions) pack = self.createPack(revisions)
if self.paramsavailable: if self.paramsavailable:
self.assertEqual(pack.params.fanoutprefix, self.assertEqual(pack.params.fanoutprefix,
basepack.LARGEFANOUTPREFIX) basepack.LARGEFANOUTPREFIX)
for (filename, node), content in blobs.iteritems(): for (filename, node), content in blobs.items():
actualcontent = pack.getdeltachain(filename, node)[0][4] actualcontent = pack.getdeltachain(filename, node)[0][4]
self.assertEqual(actualcontent, content) self.assertEqual(actualcontent, content)
def testPacksCache(self): def testPacksCache(self):
"""Test that we remember the most recent packs while fetching the delta """Test that we remember the most recent packs while fetching the delta
chain.""" chain."""
packdir = self.makeTempDir() packdir = self.makeTempDir()