tests: perform a shallow copy instead of a deep copy
ClosedPublic

Authored by indygreg on Jan 30 2019, 7:54 PM.

Details

Summary

Python 3 can't perform a deep copy because it looks like symbols
in the locals() namespace are not deep-copyable. For the curious,
somehow the deepcopy() is attempting to copy objects attached to
the unittest.* functions for the running test!

We don't use deepcopy() anywhere in the code base and a shallow
object copy should be sufficient to test lock copying.

Actually, I'm not sure why we even test this, as I couldn't find
copy.copy() being used for lock copying either. Who knows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
indygreg created this revision.Jan 30 2019, 7:54 PM
This revision was automatically updated to reflect the committed changes.