This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5795

py3: replace print() with assert in test-demandimport.py
ClosedPublic

Authored by indygreg on Feb 1 2019, 7:48 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdffd6a301570: py3: replace print() with assert in test-demandimport.py
rHG424c4e9577df: py3: replace print() with assert in test-demandimport.py
rHGc5c1f53bcb3c: py3: replace print() with assert in test-demandimport.py
rHG59ccc976ad3d: py3: replace print() with assert in test-demandimport.py
Summary

Behavior of demand imports behaves differently between Python 2 and 3.
.out files do not support conditional output the way that .t files do.
In order to make this test work on Python 3, we'll need to make the
test itself conditional.

The first step of this is to port the test to not use a .out file
to compare output.

Unfortunately, we can't easily use the unittest framework for
defining this test because putting import statements in functions
changes the behavior of the demand importer (at least on Python 2).
So, we effectively replace a bunch of print() with assert statements.

This makes the test a bit annoying to debug, as the test will
stop at first assertion failure. But we don't exactly have
a good alternative.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 1 2019, 7:48 PM
Closed by commit rHG59ccc976ad3d: py3: replace print() with assert in test-demandimport.py (authored by indygreg). · Explain WhyFeb 1 2019, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13686

tests/test-demandimport.py

from __future__ import absolute_import, print_function from __future__ import absolute_import
from mercurial import demandimport from mercurial import demandimport
demandimport.enable() demandimport.enable()
import os import os
import subprocess import subprocess
import sys import sys
# Only run if demandimport is allowed # Only run if demandimport is allowed
if subprocess.call(['python', '%s/hghave' % os.environ['TESTDIR'], if subprocess.call(['python', '%s/hghave' % os.environ['TESTDIR'],
'demandimport']): 'demandimport']):
sys.exit(80) sys.exit(80)
# We rely on assert, which gets optimized out.
if sys.flags.optimize:
sys.exit(80)
if os.name != 'nt': if os.name != 'nt':
try: try:
import distutils.msvc9compiler import distutils.msvc9compiler
print('distutils.msvc9compiler needs to be an immediate ' print('distutils.msvc9compiler needs to be an immediate '
'importerror on non-windows platforms') 'importerror on non-windows platforms')
distutils.msvc9compiler distutils.msvc9compiler
except ImportError: except ImportError:
pass pass
import re import re
rsub = re.sub rsub = re.sub
def f(obj): def f(obj):
l = repr(obj) l = repr(obj)
l = rsub("0x[0-9a-fA-F]+", "0x?", l) l = rsub("0x[0-9a-fA-F]+", "0x?", l)
l = rsub("from '.*'", "from '?'", l) l = rsub("from '.*'", "from '?'", l)
l = rsub("'<[a-z]*>'", "'<whatever>'", l) l = rsub("'<[a-z]*>'", "'<whatever>'", l)
return l return l
demandimport.disable() demandimport.disable()
os.environ['HGDEMANDIMPORT'] = 'disable' os.environ['HGDEMANDIMPORT'] = 'disable'
# this enable call should not actually enable demandimport! # this enable call should not actually enable demandimport!
demandimport.enable() demandimport.enable()
from mercurial import node from mercurial import node
print("node =", f(node))
# We use assert instead of a unittest test case because having imports inside
# functions changes behavior of the demand importer.
assert f(node) == "<module 'mercurial.node' from '?'>", f(node)
# now enable it for real # now enable it for real
del os.environ['HGDEMANDIMPORT'] del os.environ['HGDEMANDIMPORT']
demandimport.enable() demandimport.enable()
# Test access to special attributes through demandmod proxy # Test access to special attributes through demandmod proxy
from mercurial import error as errorproxy from mercurial import error as errorproxy
print("errorproxy =", f(errorproxy)) assert f(errorproxy) == "<unloaded module 'error'>", f(errorproxy)
print("errorproxy.__doc__ = %r" doc = ' '.join(errorproxy.__doc__.split()[:3])
% (' '.join(errorproxy.__doc__.split()[:3]) + ' ...')) assert doc == 'Mercurial exceptions. This', doc
print("errorproxy.__name__ = %r" % errorproxy.__name__) assert errorproxy.__name__ == 'mercurial.error', errorproxy.__name__
# __name__ must be accessible via __dict__ so the relative imports can be # __name__ must be accessible via __dict__ so the relative imports can be
# resolved # resolved
print("errorproxy.__dict__['__name__'] = %r" % errorproxy.__dict__['__name__']) name = errorproxy.__dict__['__name__']
print("errorproxy =", f(errorproxy)) assert name == 'mercurial.error', name
assert f(errorproxy) == "<proxied module 'error'>", f(errorproxy)
import os import os
print("os =", f(os)) assert f(os) == "<unloaded module 'os'>", f(os)
print("os.system =", f(os.system)) assert f(os.system) == '<built-in function system>', f(os.system)
print("os =", f(os)) assert f(os) == "<module 'os' from '?'>", f(os)
from mercurial.utils import procutil from mercurial.utils import procutil
print("procutil =", f(procutil)) assert f(procutil) == "<unloaded module 'procutil'>", f(procutil)
print("procutil.system =", f(procutil.system)) assert f(procutil.system) == '<function system at 0x?>', f(procutil.system)
print("procutil =", f(procutil)) assert f(procutil) == "<module 'mercurial.utils.procutil' from '?'>", f(procutil)
print("procutil.system =", f(procutil.system)) assert f(procutil.system) == '<function system at 0x?>', f(procutil.system)
from mercurial import hgweb from mercurial import hgweb
print("hgweb =", f(hgweb)) assert f(hgweb) == "<unloaded module 'hgweb'>", f(hgweb)
print("hgweb_mod =", f(hgweb.hgweb_mod)) assert f(hgweb.hgweb_mod) == "<unloaded module 'hgweb_mod'>", f(hgweb.hgweb_mod)
print("hgweb =", f(hgweb)) assert f(hgweb) == "<module 'mercurial.hgweb' from '?'>", f(hgweb)
import re as fred import re as fred
print("fred =", f(fred)) assert f(fred) == "<unloaded module 're'>", f(fred)
import re as remod import re as remod
print("remod =", f(remod)) assert f(remod) == "<unloaded module 're'>", f(remod)
import sys as re import sys as re
print("re =", f(re)) assert f(re) == "<unloaded module 'sys'>", f(re)
print("fred =", f(fred)) assert f(fred) == "<unloaded module 're'>", f(fred)
print("fred.sub =", f(fred.sub)) assert f(fred.sub) == '<function sub at 0x?>', f(fred.sub)
print("fred =", f(fred)) assert f(fred) == "<proxied module 're'>", f(fred)
remod.escape # use remod remod.escape # use remod
print("remod =", f(remod)) assert f(remod) == "<module 're' from '?'>", f(remod)
print("re =", f(re)) assert f(re) == "<unloaded module 'sys'>", f(re)
print("re.stderr =", f(re.stderr)) assert f(re.stderr) == "<open file '<whatever>', mode 'w' at 0x?>", f(re.stderr)
print("re =", f(re)) assert f(re) == "<proxied module 'sys'>", f(re)
import contextlib import contextlib
print("contextlib =", f(contextlib)) assert f(contextlib) == "<unloaded module 'contextlib'>", f(contextlib)
try: try:
from contextlib import unknownattr from contextlib import unknownattr
print('no demandmod should be created for attribute of non-package ' assert False, ('no demandmod should be created for attribute of non-package '
'module:\ncontextlib.unknownattr =', f(unknownattr)) 'module:\ncontextlib.unknownattr = %s' % f(unknownattr))
except ImportError as inst: except ImportError as inst:
print('contextlib.unknownattr = ImportError: %s' assert rsub(r"'", '', str(inst)) == 'cannot import name unknownattr'
% rsub(r"'", '', str(inst)))
from mercurial import util from mercurial import util
# Unlike the import statement, __import__() function should not raise # Unlike the import statement, __import__() function should not raise
# ImportError even if fromlist has an unknown item # ImportError even if fromlist has an unknown item
# (see Python/import.c:import_module_level() and ensure_fromlist()) # (see Python/import.c:import_module_level() and ensure_fromlist())
contextlibimp = __import__('contextlib', globals(), locals(), ['unknownattr']) contextlibimp = __import__('contextlib', globals(), locals(), ['unknownattr'])
print("__import__('contextlib', ..., ['unknownattr']) =", f(contextlibimp)) assert f(contextlibimp) == "<module 'contextlib' from '?'>", f(contextlibimp)
print("hasattr(contextlibimp, 'unknownattr') =", assert not util.safehasattr(contextlibimp, 'unknownattr')
util.safehasattr(contextlibimp, 'unknownattr'))

tests/test-demandimport.py.out

  • This file was deleted.
node = <module 'mercurial.node' from '?'>
errorproxy = <unloaded module 'error'>
errorproxy.__doc__ = 'Mercurial exceptions. This ...'
errorproxy.__name__ = 'mercurial.error'
errorproxy.__dict__['__name__'] = 'mercurial.error'
errorproxy = <proxied module 'error'>
os = <unloaded module 'os'>
os.system = <built-in function system>
os = <module 'os' from '?'>
procutil = <unloaded module 'procutil'>
procutil.system = <function system at 0x?>
procutil = <module 'mercurial.utils.procutil' from '?'>
procutil.system = <function system at 0x?>
hgweb = <unloaded module 'hgweb'>
hgweb_mod = <unloaded module 'hgweb_mod'>
hgweb = <module 'mercurial.hgweb' from '?'>
fred = <unloaded module 're'>
remod = <unloaded module 're'>
re = <unloaded module 'sys'>
fred = <unloaded module 're'>
fred.sub = <function sub at 0x?>
fred = <proxied module 're'>
remod = <module 're' from '?'>
re = <unloaded module 'sys'>
re.stderr = <open file '<whatever>', mode 'w' at 0x?>
re = <proxied module 'sys'>
contextlib = <unloaded module 'contextlib'>
contextlib.unknownattr = ImportError: cannot import name unknownattr
__import__('contextlib', ..., ['unknownattr']) = <module 'contextlib' from '?'>
hasattr(contextlibimp, 'unknownattr') = False
tests/test-demandimport.py