revert: added prompt before undeleting a file in -i(issue6008)
ClosedPublic

Authored by taapas1128 on Feb 2 2019, 2:56 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
taapas1128 created this revision.Feb 2 2019, 2:56 PM
taapas1128 edited the summary of this revision. (Show Details)Feb 2 2019, 2:58 PM
taapas1128 updated this revision to Diff 13703.Feb 2 2019, 3:06 PM
taapas1128 retitled this revision from revert: added prompt before undeleting a file(issue6008) to revert: added prompt before undeleting a file in -i(issue6008).
yuja added a subscriber: yuja.Feb 2 2019, 9:36 PM

+ if interactive:
+ choice = repo.ui.promptchoice(
+ _("Undelete file %s (Yn)?$$ &Yes $$ &No") % f)

Nit: "undelete" (no capital letter) per Mercurial's convention.

And I don't think "undelete" is good for user-facing messages. Perhaps, it
can be phrased as "add back removed file %s (Yn)?".

taapas1128 updated this revision to Diff 13711.Feb 2 2019, 11:17 PM
taapas1128 edited the summary of this revision. (Show Details)

@yuja thanks for the review . I have updated the revision please tell if anything else needs to be done.

This revision was automatically updated to reflect the committed changes.