This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5808

py3: do a fsdecode(), fsencode() dance in posix.py
ClosedPublic

Authored by pulkit on Feb 3 2019, 7:13 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3ef8bec91465: py3: do a fsdecode(), fsencode() dance in posix.py
rHG9d7e1cde0097: py3: do a fsdecode(), fsencode() dance in posix.py
rHG512eb4af4295: py3: do a fsdecode(), fsencode() dance in posix.py
Summary

We have to use fsdecode() instead of sysstr() because they are abusing
PyUnicode_EncodeFSDefault() to get back bytes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 3 2019, 7:13 AM
Closed by commit rHG512eb4af4295: py3: do a fsdecode(), fsencode() dance in posix.py (authored by pulkit). · Explain WhyFeb 3 2019, 7:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/posix.py (4 lines)

Diff 13721

mercurial/posix.py

return grp.getgrgid(gid)[0] return grp.getgrgid(gid)[0]
except KeyError: except KeyError:
return str(gid) return str(gid)
def groupmembers(name): def groupmembers(name):
"""Return the list of members of the group with the given """Return the list of members of the group with the given
name, KeyError if the group does not exist. name, KeyError if the group does not exist.
""" """
name = pycompat.sysstr(name) name = pycompat.fsdecode(name)
return list(grp.getgrnam(name).gr_mem) return pycompat.rapply(pycompat.fsencode, list(grp.getgrnam(name).gr_mem))
def spawndetached(args): def spawndetached(args):
return os.spawnvp(os.P_NOWAIT | getattr(os, 'P_DETACH', 0), return os.spawnvp(os.P_NOWAIT | getattr(os, 'P_DETACH', 0),
args[0], args) args[0], args)
def gethgcmd(): def gethgcmd():
return sys.argv[:1] return sys.argv[:1]