This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5819

crecord: use raw string for regular expression
ClosedPublic

Authored by indygreg on Feb 4 2019, 12:19 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7a90ff8cd14c: crecord: use raw string for regular expression
Summary

\s emits a SyntaxWarning in Python 3.8. Use a raw string to
avoid escaping the \.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 4 2019, 12:19 PM
Closed by commit rHG7a90ff8cd14c: crecord: use raw string for regular expression (authored by indygreg). · Explain WhyFeb 4 2019, 6:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13779

mercurial/crecord.py

self.errorstr = None self.errorstr = None
continue continue
except curses.error: except curses.error:
keypressed = "foobar" keypressed = "foobar"
if self.handlekeypressed(keypressed): if self.handlekeypressed(keypressed):
break break
if self.commenttext != "": if self.commenttext != "":
whitespaceremoved = re.sub("(?m)^\s.*(\n|$)", "", self.commenttext) whitespaceremoved = re.sub(br"(?m)^\s.*(\n|$)", b"",
self.commenttext)
if whitespaceremoved != "": if whitespaceremoved != "":
self.opts['message'] = self.commenttext self.opts['message'] = self.commenttext