This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5844

check-py3-compat: provide filename to ast.parse()
ClosedPublic

Authored by indygreg on Feb 4 2019, 5:47 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG01417ca7f2e2: check-py3-compat: provide filename to ast.parse()
Summary

This ensures any warning/error messages print a valid filename instead of
potentially '<unknown>'.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 4 2019, 5:47 PM
Closed by commit rHG01417ca7f2e2: check-py3-compat: provide filename to ast.parse() (authored by indygreg). · Explain WhyFeb 4 2019, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-py3-compat.py (2 lines)

Diff 13798

contrib/check-py3-compat.py

print('%s requires print_function' % f) print('%s requires print_function' % f)
def check_compat_py3(f): def check_compat_py3(f):
"""Check Python 3 compatibility of a file with Python 3.""" """Check Python 3 compatibility of a file with Python 3."""
with open(f, 'rb') as fh: with open(f, 'rb') as fh:
content = fh.read() content = fh.read()
try: try:
ast.parse(content) ast.parse(content, filename=f)
except SyntaxError as e: except SyntaxError as e:
print('%s: invalid syntax: %s' % (f, e)) print('%s: invalid syntax: %s' % (f, e))
return return
# Try to import the module. # Try to import the module.
# For now we only support modules in packages because figuring out module # For now we only support modules in packages because figuring out module
# paths for things not in a package can be confusing. # paths for things not in a package can be confusing.
if (f.startswith(('hgdemandimport/', 'hgext/', 'mercurial/')) if (f.startswith(('hgdemandimport/', 'hgext/', 'mercurial/'))