This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5878

py3: make sure __repr__ returns str
ClosedPublic

Authored by pulkit on Feb 7 2019, 9:06 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3751595ec45e: py3: make sure __repr__ returns str
Summary

No test fails but I found it while debugging test-commit-interactive-curses.t
failure.

  1. skip-blame because just r'' prefix

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 7 2019, 9:06 AM
Closed by commit rHG3751595ec45e: py3: make sure __repr__ returns str (authored by pulkit). · Explain WhyFeb 9 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/patch.py (2 lines)

Diff 13954

mercurial/patch.py

if bfile == '/dev/null': if bfile == '/dev/null':
return self.op == 'DELETE' return self.op == 'DELETE'
return bfile == 'b/' + self.path return bfile == 'b/' + self.path
def ispatching(self, afile, bfile): def ispatching(self, afile, bfile):
return self._ispatchinga(afile) and self._ispatchingb(bfile) return self._ispatchinga(afile) and self._ispatchingb(bfile)
def __repr__(self): def __repr__(self):
return "<patchmeta %s %r>" % (self.op, self.path) return r"<patchmeta %s %r>" % (self.op, self.path)
def readgitpatch(lr): def readgitpatch(lr):
"""extract git-style metadata about patches from <patchname>""" """extract git-style metadata about patches from <patchname>"""
# Filter patch for git information # Filter patch for git information
gp = None gp = None
gitpatches = [] gitpatches = []
for line in lr: for line in lr: